[
https://issues.apache.org/jira/browse/FLINK-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351108#comment-15351108
]
ASF GitHub Bot commented on FLINK-3319:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2155
Thank you very much for your contribution @thormanrd. The CEP changes look
really good :-)
The only thing which we could improve is to add a unit test for the
`OrFilterFunction`.
Moreover, it would be good to revert the unrelated changes (probably
introduced by auto-formatting) to the non CEP related files. Otherwise we
cannot merge your PR.
> Add or operator to CEP's pattern API
> ------------------------------------
>
> Key: FLINK-3319
> URL: https://issues.apache.org/jira/browse/FLINK-3319
> Project: Flink
> Issue Type: Improvement
> Components: CEP
> Affects Versions: 1.0.0
> Reporter: Till Rohrmann
> Assignee: Robert Thorman
> Priority: Minor
>
> Adding an {{or}} operator to CEP's pattern API would be beneficial. This
> would considerably extend the set of supported patterns. The {{or}} operator
> lets you define multiple succeeding pattern states for the next stage.
> {code}
> Pattern.begin("start").next("middle1").where(...).or("middle2").where(...)
> {code}
> In order to implement the {{or}} operator, one has to extend the {{Pattern}}
> class. Furthermore, the {{NFACompiler}} has to be extended to generate two
> resulting pattern states in case of an {{or}} operator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
