Airblader commented on a change in pull request #17481: URL: https://github.com/apache/flink/pull/17481#discussion_r728896329
########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/JsonStringCallGen.scala ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.codegen.calls + +import org.apache.flink.table.planner.codegen.CodeGenUtils.{BINARY_STRING, className, newName, primitiveTypeTermForType} +import org.apache.flink.table.planner.codegen.JsonGenerateUtils.createNodeTerm +import org.apache.flink.table.planner.codegen.{CodeGeneratorContext, GeneratedExpression} +import org.apache.flink.table.runtime.functions.SqlJsonUtils +import org.apache.flink.table.types.logical.LogicalType + +import org.apache.calcite.rex.RexCall + +/** [[CallGenerator]] for `JSON_STRING`. */ +class JsonStringCallGen(call: RexCall) extends CallGenerator { + private def jsonUtils = className[SqlJsonUtils] + + override def generate( + ctx: CodeGeneratorContext, + operands: Seq[GeneratedExpression], + returnType: LogicalType): GeneratedExpression = { + + val valueTerm = createNodeTerm(ctx, operands.head, call.operands.get(0)) Review comment: I reckon that once (and if) we rewrite `JSON_OBJECT`, `JSON_ARRAY` to use the same trick that we're planning for `JSON_OBJECTAGG` and `JSON_ARRAYAGG`, we can convert `JSON_STRING` from a code-generated function into a nice little Java class. But for the moment we should re-use the existing code generation we have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
