Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2128#discussion_r68654363
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -76,6 +76,9 @@ public void open(Configuration config) throws Exception {
try {
connection = factory.newConnection();
channel = connection.createChannel();
+ if (channel == null) {
--- End diff --
As far as I understand in RabbitMQ every real TCP connection has a number
of virtual connections implemented on top of it. If we request a channel and
it's not available "createChannel" returns null.
I've updated the exception message to reflect that.
I don't think this generally will be an issue, since we only request one
channel for a connection, but it would be beneficial to throw an exception with
an appropriate message instead of a NullPointerException in case if anything
goes wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
