RyanSkraba commented on a change in pull request #17451:
URL: https://github.com/apache/flink/pull/17451#discussion_r730775316
##########
File path:
flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java
##########
@@ -78,10 +78,10 @@ public Elasticsearch6DynamicSink(
// on the sink itself.
// --------------------------------------------------------------
- private final ElasticSearchBuilderProvider builderProvider;
+ private final ElasticsearchBuilderProvider builderProvider;
@FunctionalInterface
- interface ElasticSearchBuilderProvider {
+ interface ElasticsearchBuilderProvider {
Review comment:
I set the entire `Elasticsearch6DynamicSink` as `@Internal` -- this
seems to be the case for other `DynamicTableSink` implementations, and
consistent with `Elasticsearch7DynamicSink`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
