twalthr commented on a change in pull request #17439:
URL: https://github.com/apache/flink/pull/17439#discussion_r730838887
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java
##########
@@ -411,7 +411,7 @@ public String toString() {
return "[API] "
+ expression.stream()
.map(Expression::asSummaryString)
- .collect(Collectors.joining());
+ .collect(Collectors.joining(", "));
Review comment:
usually, our commit tags should describe the Maven module that they
touch mostly, so for the hotfix commit it woul d be `[hotfix][table-planner]`,
`[test]` sounds more like `flink-tests`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
