dawidwys commented on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-945691431
I understand `notifyNewBufferSize`, `resumeConsumption` and `acknowledgeAllRecordsProcessed` was added that way, because of how `notifyCreditAvailable` was introduced. I think it was added inside of the `NetworkClienHandler` in order to have two parallel implementations for credit-based and the legacy flow control and there were already two classes for those. Overall, I think that was an unfortunate choice. I'd recommend trying out what I am suggesting. It should fix the issue of the thread, because we would use netty mechanisms exclusively and we would not depend that the activation message comes first. @akalash would you like to try it out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
