slinkydeveloper commented on a change in pull request #17441:
URL: https://github.com/apache/flink/pull/17441#discussion_r731092407
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/CollectDynamicSink.java
##########
@@ -115,6 +105,9 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context
context) {
externalSerializer,
accumulatorName,
checkpointConfig);
+ this.converter =
context.createDataStructureConverter(consumedDataType);
+ this.converter.open(
+
RuntimeConverter.Context.create(config.getClass().getClassLoader()));
Review comment:
Given this lambda runs in the same classloader of the table environment,
i think using the current thread classloader just makes sense?
> I would call the open() later.
Do you have any specific location where you would call it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
