Airblader commented on a change in pull request #17481:
URL: https://github.com/apache/flink/pull/17481#discussion_r731548152
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -1145,6 +1145,16 @@ public boolean isDeterministic() {
public static final SqlFunction JSON_EXISTS =
SqlStdOperatorTable.JSON_EXISTS;
public static final SqlFunction JSON_VALUE =
SqlStdOperatorTable.JSON_VALUE;
public static final SqlFunction JSON_QUERY =
SqlStdOperatorTable.JSON_QUERY;
+ public static final SqlFunction JSON_STRING =
+ new SqlFunction(
+ "JSON_STRING",
+ SqlKind.OTHER_FUNCTION,
+ ReturnTypes.cascade(
+ ReturnTypes.explicit(SqlTypeName.VARCHAR),
+ FlinkReturnTypes.TO_NULLABLE_SHALLOW),
Review comment:
But isn't it the other way around here, i.e. the outer nullability
depends on the inner nullability?
Also, just to make sure, you're not saying I should change this, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
