twalthr commented on a change in pull request #17439:
URL: https://github.com/apache/flink/pull/17439#discussion_r731888330
##########
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/TypeCheckUtils.java
##########
@@ -45,6 +45,10 @@ public static boolean isNumeric(LogicalType type) {
return
type.getTypeRoot().getFamilies().contains(LogicalTypeFamily.NUMERIC);
}
+ public static boolean isIntegerNumeric(LogicalType type) {
Review comment:
use `LogicalTypeChecks.hasFamily()` instead? we should avoid introducing
to many utilities that basically do the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
