[ 
https://issues.apache.org/jira/browse/FLINK-24384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430664#comment-17430664
 ] 

Feifan Wang commented on FLINK-24384:
-------------------------------------

Hi [~pnowojski], I test the pr of FLINK-24344 just now. It make IOException 
thrown by 
_*CheckpointStorageCoordinatorView#initializeLocationForCheckpoint(long 
checkpointId)*_ reaches _*CheckpointFailureManager*_, thus it make 
tolerableCheckpointFailureNumber can effect. But it still does not count 
failures into numberOfFailedCheckpoints.

A common use case is to configure a relatively large 
tolerableCheckpointFailureNumber to prevent the job full restart, still want 
aware _*CheckpointStorageCoordinatorView#initializeLocationForCheckpoint(long 
checkpointId)*_ through metric of numberOfFailedCheckpoints.

> Count checkpoints failed in trigger phase into numberOfFailedCheckpoints
> ------------------------------------------------------------------------
>
>                 Key: FLINK-24384
>                 URL: https://issues.apache.org/jira/browse/FLINK-24384
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Checkpointing
>            Reporter: Feifan Wang
>            Priority: Major
>
> h1. *Problem*
> In current implementation, checkpoints failed in trigger phase do not count 
> into metric 'numberOfFailedCheckpoints'. Such that users can not aware 
> checkpoint stoped by this metric.
> As lang as users can use rules like _*'numberOfCompletedCheckpoints' not 
> increase in some minutes past*_ (maybe checkpoint interval + timeout) for 
> alerting, but I think it is ambages and can not alert timely.
>  
> h1. *Proposal*
> As the title, count checkpoints failed in trigger phase into 
> 'numberOfFailedCheckpoints'.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to