dmvk commented on a change in pull request #17493:
URL: https://github.com/apache/flink/pull/17493#discussion_r732726904
##########
File path: flink-dist/src/main/assemblies/bin.xml
##########
@@ -69,6 +69,14 @@ under the License.
<fileMode>0644</fileMode>
</file>
+ <!-- Scala APIs -->
+ <file>
+
<source>../flink-dist-scala/target/flink-dist-scala_${scala.binary.version}-${project.version}.jar</source>
+ <outputDirectory>lib/</outputDirectory>
+
<destName>flink-scala_${scala.binary.version}-${project.version}.jar</destName>
Review comment:
Should we change the destination name to `flink-dist-scala` here?
```suggestion
<destName>flink-dist-scala_${scala.binary.version}-${project.version}.jar</destName>
```
##########
File path: flink-dist-scala/pom.xml
##########
@@ -0,0 +1,125 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-parent</artifactId>
+ <version>1.15-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+
+ <artifactId>flink-dist-scala_${scala.binary.version}</artifactId>
+ <name>Flink : Dist-Scala</name>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-scala_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <!-- transitive Flink dependencies are
provided at runtime -->
+ <groupId>org.apache.flink</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-streaming-scala_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <!-- transitive Flink dependencies are
provided at runtime -->
+ <groupId>org.apache.flink</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <!-- Provided by flink-dist -->
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <!-- Provided by flink-dist -->
+ <groupId>com.google.code.findbugs</groupId>
+ <artifactId>jsr305</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ </dependencies>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <!-- Provided by flink-dist -->
+ <groupId>com.twitter</groupId>
+ <artifactId>chill-java</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <artifactSet>
+ <includes>
+ <!--
Explicitly include Flink APIs and Scala.
+
Transitive dependencies are bundled by _either_ flink-dist(-scala),
+
and we need to make sure no dependency required for the Scala-free
+
operation of Flink is bundled in flink-dist-scala. -->
+
<include>org.apache.flink:*</include>
+
<include>org.scala-lang*:*</include>
+
<include>com.twitter:chill_${scala.binary.version}</include>
+ </includes>
+ </artifactSet>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-deploy-plugin</artifactId>
+ <version>2.4</version><!--$NO-MVN-MAN-VER$-->
Review comment:
why are we downgrading the deploy-plugin version here (from 2.8.2 used
in the Apache parent)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
