[ 
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352704#comment-15352704
 ] 

ASF GitHub Bot commented on FLINK-1550:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2146#discussion_r68729084
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
 ---
    @@ -1082,6 +1110,13 @@ class JobManager(
     
             log.info(s"Using restart strategy $restartStrategy for $jobId.")
     
    +        val jobMetrics = jobManagerMetricGroup match {
    +          case Some(group) =>
    +            group.addJob(jobGraph.getJobID, jobGraph.getName)
    --- End diff --
    
    What happens if `group.addJob` returns a `null` value? Then the 
instantiation of the `ExecutionGraph` would fail with a `NullPointerException`. 
We should check that and return an `UnregisteredMetricsGroup` instead.


> Show JVM Metrics for JobManager
> -------------------------------
>
>                 Key: FLINK-1550
>                 URL: https://issues.apache.org/jira/browse/FLINK-1550
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager, Metrics
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>             Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to