nicoweidner commented on a change in pull request #17474:
URL: https://github.com/apache/flink/pull/17474#discussion_r733530706
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/async/AbstractAsynchronousOperationHandlersTest.java
##########
@@ -194,11 +195,12 @@ public void testUnknownTriggerId() throws Exception {
*/
@Test
public void testCloseShouldFinishOnFirstServedResult() throws Exception {
- final CompletableFuture<String> savepointFuture = new
CompletableFuture<>();
+ final CompletableFuture<Acknowledge> acknowledgeFuture = new
CompletableFuture<>();
final TestingRestfulGateway testingRestfulGateway =
new TestingRestfulGateway.Builder()
.setTriggerSavepointFunction(
- (JobID jobId, String directory) ->
savepointFuture)
+ (AsynchronousJobOperationKey operationKey,
String directory) ->
Review comment:
Yeah, I was also a bit irritated that this test for the abstract class
used details about the concrete implementations in this way. I will try
extending TestingRestfulGateway for this test and adding a custom method to the
extension (so we do not depend on existing methods, which will all throw anyway
if used).
I guess I made the situation worse since now SavepointHandlers doesn't even
extend AsyncOperationHandlers anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
