twalthr commented on a change in pull request #17550:
URL: https://github.com/apache/flink/pull/17550#discussion_r735605118
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeCasts.java
##########
@@ -500,8 +497,7 @@ public Boolean visit(VarCharType targetType) {
return false;
}
// CHAR and VARCHAR are very compatible within bounds
- if ((hasRoot(sourceType, LogicalTypeRoot.CHAR)
- || hasRoot(sourceType, LogicalTypeRoot.VARCHAR))
+ if ((sourceType.isAnyOf(LogicalTypeRoot.CHAR,
LogicalTypeRoot.VARCHAR))
Review comment:
redundant parenthesis
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeCasts.java
##########
@@ -514,8 +510,7 @@ public Boolean visit(VarBinaryType targetType) {
return false;
}
// BINARY and VARBINARY are very compatible within bounds
- if ((hasRoot(sourceType, LogicalTypeRoot.BINARY)
- || hasRoot(sourceType, LogicalTypeRoot.VARBINARY))
+ if ((sourceType.isAnyOf(LogicalTypeRoot.BINARY,
LogicalTypeRoot.VARBINARY))
Review comment:
redundant parenthesis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
