pnowojski commented on a change in pull request #17473:
URL: https://github.com/apache/flink/pull/17473#discussion_r735657956



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/bufferdebloat/BufferDebloater.java
##########
@@ -94,10 +97,10 @@ public void recalculateBufferSize(long currentThroughput) {
             return;
         }
 
-        lastBufferSize = newSize;
         for (IndexedInputGate inputGate : inputGates) {
             inputGate.announceBufferSize(newSize);
         }
+        lastBufferSize = newSize;

Review comment:
       Ok, I see. So it's not related to the EMA calculation and FLINK-24470 
after all? If so, can you extract this to a separate commit, with this 
explanation in the commit message? Maybe (I'm not sure) also adding a short 
comment in the code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to