alpreu commented on a change in pull request #17538:
URL: https://github.com/apache/flink/pull/17538#discussion_r735672210
##########
File path:
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBuilderBaseTest.java
##########
@@ -24,62 +24,56 @@
import org.apache.http.HttpHost;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestInstance;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
import java.util.List;
import static org.junit.jupiter.api.Assertions.assertThrows;
-/** Tests for {@link ElasticsearchSinkBuilder}. */
-class ElasticsearchSinkBuilderTest extends TestLogger {
+/** Tests for {@link ElasticsearchSinkBuilderBase}. */
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
Review comment:
We need it for the ParameterizedTest of the non-static validBuilders()
method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
