Github user vasia commented on the issue:
https://github.com/apache/flink/pull/1967
Hey @greghogan,
was there consensus regarding this change? I see the numbers, but did
anyone review this PR?
I've been offline for the past few days, and I now see that nobody reviewed
#2160, #2079, #2067, #1997 either...
I don't doubt that you have done a great job, but it is _always_ better to
let someone review your code before you merge. We don't usually merge PRs
without a +1 unless it is something trivial. I understand things move faster
this way, but we are in a community and we should try to collaborate.
Please, leave a comment next time you think a PR has stayed with no review
for a long time or ping me personally if you want a 2nd pair of eyes on gelly
stuff :)
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
