akalash commented on a change in pull request #17559:
URL: https://github.com/apache/flink/pull/17559#discussion_r738130783
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java
##########
@@ -1133,23 +1133,27 @@ public InvokableWithExceptionOnTrigger(Environment
environment) {
@Override
public void invoke() {
- awaitLatch.trigger();
-
- // make sure that the interrupt call does not
- // grab us out of the lock early
- while (true) {
- try {
- triggerLatch.await();
- break;
- } catch (InterruptedException e) {
- // fall through the loop
- }
- }
+ awaitTriggerLatch();
throw new RuntimeException("test");
}
}
+ private static void awaitTriggerLatch() {
+ awaitLatch.trigger();
+
+ // make sure that the interrupt call does not
+ // grab us out of the lock early
+ while (true) {
+ try {
+ triggerLatch.await();
+ break;
+ } catch (InterruptedException e) {
Review comment:
No, unfortunately, it doesn't explain. `failExternally` does the
expected interrupt but I see that the interrupt happens before we call
`failExternally` which leads to the problem that we observe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
