slinkydeveloper commented on a change in pull request #17544:
URL: https://github.com/apache/flink/pull/17544#discussion_r739062795
##########
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSink.java
##########
@@ -281,32 +282,46 @@ private RowDataPartitionComputer partitionComputer() {
}
private Optional<CompactReader.Factory<RowData>>
createCompactReaderFactory(Context context) {
- if (bulkReaderFormat != null) {
- final BulkFormat<RowData, FileSourceSplit> format =
- bulkReaderFormat.createRuntimeDecoder(
- createSourceContext(context),
getPhysicalDataType());
- return Optional.of(CompactBulkReader.factory(format));
- } else if (formatFactory != null) {
+ // TODO FLINK-19845 old format factory, to be removed soon.
+ if (formatFactory != null) {
final InputFormat<RowData, ?> format =
formatFactory.createReader(createReaderContext());
if (format instanceof FileInputFormat) {
//noinspection unchecked
return Optional.of(
FileInputFormatCompactReader.factory((FileInputFormat<RowData>) format));
}
+ return Optional.empty();
+ }
+
+ // Compute fullOutputDataType (including partition fields) and
physicalDataType (excluding
+ // partition fields)
+ final DataType fullOutputDataType = getPhysicalDataType();
Review comment:
Renamed to `producedDataType` (same in source)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
