gaoyunhaii commented on a change in pull request #14:
URL: https://github.com/apache/flink-ml/pull/14#discussion_r739765096
##########
File path: flink-ml-iteration/pom.xml
##########
@@ -61,6 +61,14 @@ under the License.
<scope>provided</scope>
</dependency>
+ <!-- We have special treatment with the rocksdb state. -->
Review comment:
I think we might not since in the main code we have references to
rocksdb related classes. With provided, the dependency would also not be
included into the jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
