twalthr commented on pull request #17444: URL: https://github.com/apache/flink/pull/17444#issuecomment-956042111
@godfreyhe Please pay attention to the code quality. This PR adds more legacy: ``` @Rule public LegacyRowResource usesLegacyRows = LegacyRowResource.INSTANCE; ``` which could have been avoided. Also, when opening `ImplicitTypeConversionITCase` in an IDE, the file is full warnings. `toAppendStream`, `registerTable` all of that is deprecated. `DataStreamConversions` is for implicit conversions. Not intended for Java code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
