[ 
https://issues.apache.org/jira/browse/FLINK-23990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436726#comment-17436726
 ] 

Junhan Yang commented on FLINK-23990:
-------------------------------------

Hey, [~airblader]. As we discussed earlier, I have replaced the old custom 
editor component with the one shipped in NG-Zorro. Some existing stylesheets 
are a bit messy and hard to maintain (not to mention unresponsive), so I have 
to re-define some of those to make the new editor work. With that being said, 
we may need an individual PR to improve the whole app's styles to make it more 
elegant and maintainable.

> Replace custom monaco editor component
> --------------------------------------
>
>                 Key: FLINK-23990
>                 URL: https://issues.apache.org/jira/browse/FLINK-23990
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Web Frontend
>    Affects Versions: 1.14.0
>            Reporter: Ingo Bürk
>            Priority: Minor
>              Labels: pull-request-available
>
> After the upgrade to Angular 12 we should investigate if we can't replace the 
> custom flink-monaco-editor component by the one shipped with ng-zorro. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to