iyupeng commented on a change in pull request #17344:
URL: https://github.com/apache/flink/pull/17344#discussion_r740148228
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/abilities/SupportsAggregatePushDown.java
##########
@@ -124,8 +124,6 @@
*
* <p>Regardless if this interface is implemented or not, a final aggregation
is always applied in a
* subsequent operation after the source.
- *
- * <p>Note: currently, the {@link SupportsAggregatePushDown} is not supported
by planner.
Review comment:
Hi @twalthr, the strategy is still `all or nothing` here.
`applyAggregates` returns a bool value, meaning whether all local aggregates
are accepted by underlying data source or not at all.
The docs could be improved, like mentioning the new option, etc.
I could push a hotfix for docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
