rkhachatryan commented on a change in pull request #17229:
URL: https://github.com/apache/flink/pull/17229#discussion_r740389826
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -387,6 +390,13 @@ protected StreamTask(
this.stateBackend = createStateBackend();
this.checkpointStorage = createCheckpointStorage(stateBackend);
+ this.changelogWriterAvailabilityProvider =
+ environment.getTaskStateManager().getStateChangelogStorage()
== null
+ ? () -> AvailabilityProvider.AVAILABLE // todo:
benchmark
+ : environment
+ .getTaskStateManager()
+ .getStateChangelogStorage()
+ .getAvailabilityProvider();
Review comment:
After thinking a bit more about `getStateBackendAvailabilityProvider`,
it doesn't seem the right API.
Inside a task, there can be multiple operators and therefore multiple state
backends.
In general (without sharing the underlying writers), each can have its own
availability provider.
So such API (`getTaskStateManager().getStateBackendAvailabilityProvider()`)
wouldn't make sense.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
