JingGe commented on a change in pull request #17501: URL: https://github.com/apache/flink/pull/17501#discussion_r740259768
########## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/avro/AvroParquetRecordFormat.java ########## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.formats.parquet.avro; + +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.connector.file.src.reader.RecordFormat; +import org.apache.flink.core.fs.FSDataInputStream; +import org.apache.flink.formats.avro.typeutils.GenericRecordAvroTypeInfo; + +import org.apache.avro.Schema; +import org.apache.avro.generic.GenericData; +import org.apache.avro.generic.GenericRecord; +import org.apache.parquet.avro.AvroParquetReader; +import org.apache.parquet.hadoop.ParquetReader; +import org.apache.parquet.io.DelegatingSeekableInputStream; +import org.apache.parquet.io.InputFile; +import org.apache.parquet.io.SeekableInputStream; + +import javax.annotation.Nullable; + +import java.io.IOException; + +/** */ +public class AvroParquetRecordFormat implements RecordFormat<GenericRecord> { + + private final transient Schema schema; Review comment: We are using 1.10.0 now, the `Schema` is serializable. Just out of curiosity, since the transient keyword has been used, I'd like take this opportunity to understand the Flink concept and therefore the reason why do we care about the serializable here. Will the Format object be created locally on each TM or will it created and transferred to TMs via network, which will need ser/des? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
