[ 
https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356190#comment-15356190
 ] 

ASF GitHub Bot commented on FLINK-3943:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2169#discussion_r69048019
  
    --- Diff: 
flink-scala/src/main/scala/org/apache/flink/api/scala/DataSet.scala ---
    @@ -1353,6 +1353,16 @@ class DataSet[T: ClassTag](set: JavaDataSet[T]) {
         getCallLocationName()))
     
       // 
--------------------------------------------------------------------------------------------
    +  //  Minus
    +  // 
--------------------------------------------------------------------------------------------
    +
    +  /**
    +    * Creates a new DataSet containing the elements from `this` DataSet 
minus elements from `other`
    +    * DataSet.
    +    */
    +  def minus(other: DataSet[T]): DataSet[T] = 
wrap(javaSet.minus(other.javaSet))
    --- End diff --
    
    Please remove these changes as well. Thanks


> Add support for EXCEPT (set minus)
> ----------------------------------
>
>                 Key: FLINK-3943
>                 URL: https://issues.apache.org/jira/browse/FLINK-3943
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>    Affects Versions: 1.1.0
>            Reporter: Fabian Hueske
>            Assignee: Ivan Mushketyk
>            Priority: Minor
>
> Currently, the Table API and SQL do not support EXCEPT.
> EXCEPT can be executed as a coGroup on all fields that forwards records of 
> the first input if the second input is empty.
> In order to add support for EXCEPT to the Table API and SQL we need to:
> - Implement a {{DataSetMinus}} class that translates an EXCEPT into a DataSet 
> API program using a coGroup on all fields.
> - Implement a {{DataSetMinusRule}} that translates a Calcite {{LogicalMinus}} 
> into a {{DataSetMinus}}.
> - Extend the Table API (and validation phase) to provide an except() method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to