AHeise commented on a change in pull request #17501: URL: https://github.com/apache/flink/pull/17501#discussion_r740847332
########## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/avro/AvroParquetRecordFormat.java ########## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.formats.parquet.avro; + +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.connector.file.src.reader.RecordFormat; +import org.apache.flink.core.fs.FSDataInputStream; +import org.apache.flink.formats.avro.typeutils.GenericRecordAvroTypeInfo; + +import org.apache.avro.Schema; +import org.apache.avro.generic.GenericData; +import org.apache.avro.generic.GenericRecord; +import org.apache.parquet.avro.AvroParquetReader; +import org.apache.parquet.hadoop.ParquetReader; +import org.apache.parquet.io.DelegatingSeekableInputStream; +import org.apache.parquet.io.InputFile; +import org.apache.parquet.io.SeekableInputStream; + +import javax.annotation.Nullable; + +import java.io.IOException; + +/** */ +public class AvroParquetRecordFormat implements RecordFormat<GenericRecord> { + + private final transient Schema schema; Review comment: The format will be created in the `main` of the entry point. That could be a local client or in recent settings on the job manager. The job manager will create a `JobGraph` and chop it into `Task`s to send to the task managers, where each task has configuration that contains the serialized configuration. So while the `AvroParquetRecordFormat` is in the user jar that every task manager independently has access to, the specific format instance is serialized on JM, sent to TM, and deserialized there. Hence, every user function needs to be `Serializable` (e.g. `MapFunction`) or need to be created by a serializable factory (e.g. `BulkWriter.Factory`, `StreamFormat` as a factory for the `Reader`, `Source`, `Sink`). In this case, the `AvroParquetRecordFormat` is serialized without the schema information on JM, so the TM doesn't know the schema at all and will fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
