[ 
https://issues.apache.org/jira/browse/FLINK-24741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437773#comment-17437773
 ] 

Arvid Heise commented on FLINK-24741:
-------------------------------------

While I agree that the {{FileRecordFormat}} is confusing, I think the main 
motivation for removing it is the inherent design flaw in the batching of 
{{FileRecordFormat}}: {{StreamFormat}} can guarantee that only a certain amount 
of memory is being used (unless a single record exceeds that already), but 
{{FileRecordFormat}} can only batch by the number of records. By removing 
{{FileRecordFormat}}, we relay the responsibility of implementing the batching 
to the format developer; they need to use {{BulkFormat}} and find a better way 
than batch by number of records.

> Deprecate FileRecordFormat, use StreamFormat instead
> ----------------------------------------------------
>
>                 Key: FLINK-24741
>                 URL: https://issues.apache.org/jira/browse/FLINK-24741
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / FileSystem
>            Reporter: Jing Ge
>            Assignee: Jing Ge
>            Priority: Major
>              Labels: features
>             Fix For: 1.15.0
>
>
> Issue: The FileRecordFormat and StreamFormat have too much commons. This 
> makes user confused.
> Suggestion: The currently marked as PublicEvolving interface FileRecordFormat 
> should be deprecated. The StreamFormat should be extended and recommended 
> instead. All relevant usages should be refactored and informed appropriately.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to