yangjunhan commented on a change in pull request #17619:
URL: https://github.com/apache/flink/pull/17619#discussion_r741742781
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.html
##########
@@ -16,11 +16,21 @@
~ limitations under the License.
-->
-<nz-tabset [nzSize]="'small'" [nzAnimated]="{ inkBar: true, tabPane: false }">
- <nz-tab nzTitle="Root Exception" nzForceRender>
- <flink-monaco-editor [value]="rootException"></flink-monaco-editor>
+<nz-tabset
+ [nzSize]="'small'"
+ [nzAnimated]="{ inkBar: true, tabPane: false }"
+ [(nzSelectedIndex)]="index"
+>
+ <nz-tab nzTitle="Root Exception">
+ <nz-code-editor
+ *ngIf="index === 0"
Review comment:
I just come up with a better way to do this. I would use the lazy
loading feature in
nz-tabset:https://ng.ant.design/components/tabs/en#components-tabs-demo-lazy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
