rkhachatryan commented on a change in pull request #17645:
URL: https://github.com/apache/flink/pull/17645#discussion_r742209839
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateCheckpointWriter.java
##########
@@ -296,13 +296,17 @@ private void runWithChecks(RunnableWithException r)
throws Exception {
r.run();
} catch (Exception e) {
fail(e);
- throw e;
}
}
public void fail(Throwable e) throws Exception {
Review comment:
Good point, thanks, I'll do this.
Though I'm going to partially revert this change: otherwise, programmatic
and other errors aren't propagated (that's why
`ChannelStateWriteRequestDispatcherTest` fails). But they don't have to be
declared (non-recoverable by definition).
Instead, I'm going to add something like
```
fail(e);
if (!ExceptionUtils.findThrowable(e,
IOException.class).isPresent()) {
ExceptionUtils.rethrow(e);
}
```
(but first I'd like to confirm that the original exception was indeed
`IOException`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
