zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741697624
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() ==
RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+
PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
then you can also pass null for the PluginManager.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() ==
RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+
PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
I don't think so because all tests using the `MiniClusters` implicitly
go through the `LocalEnvironment.`
While it is true that users cannot set credentials via the configuration
passed to the environment, they could call `FileSystem#initialize()` themselves.
Yes, it is surprising and not ergonomic and all that.
Alternatively we would need a way to reset the `FileSystem` (i.e., call
initialize again with no configuration) after each test.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() ==
RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+
PluginUtils.createPluginManagerFromRootFolder(configuration);
Review comment:
Filesystems can still be loaded through the FileSystemFactory service if
they are on the classpath.
Plugins in local environments are a bit eh because there's a) no sane way to
control the plugin directory (no, setting some internal env variable is not
sane) and b) you must not add a `dependency` on said FS otherwise you lose all
the benefits.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -279,6 +282,10 @@ public void start() throws Exception {
miniClusterConfiguration.getRpcServiceSharing() ==
RpcServiceSharing.SHARED;
try {
+ final PluginManager pluginManager =
+
PluginUtils.createPluginManagerFromRootFolder(configuration);
+ FileSystem.initialize(configuration, pluginManager);
Review comment:
And who calls that? Every test that uses a filesystem? Every test that
does something special? How do you enforce that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
