tillrohrmann commented on a change in pull request #17608:
URL: https://github.com/apache/flink/pull/17608#discussion_r741954872
##########
File path:
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
##########
@@ -413,7 +413,7 @@ static Object deserializeValueIfNeeded(Object o, Method
method) {
if (o instanceof AkkaRpcSerializedValue) {
try {
return ((AkkaRpcSerializedValue) o)
-
.deserializeValue(AkkaInvocationHandler.class.getClassLoader());
+
.deserializeValue(Thread.currentThread().getContextClassLoader());
Review comment:
I'd suggest to use the `flinkClassLoader` instead of the context class
loader. I think this is a bit more robust and explicit.
##########
File path:
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
##########
@@ -413,7 +413,7 @@ static Object deserializeValueIfNeeded(Object o, Method
method) {
if (o instanceof AkkaRpcSerializedValue) {
try {
return ((AkkaRpcSerializedValue) o)
-
.deserializeValue(AkkaInvocationHandler.class.getClassLoader());
+
.deserializeValue(Thread.currentThread().getContextClassLoader());
Review comment:
I'd suggest to use the `flinkClassLoader` instead of the context class
loader. I think this is a bit more robust and explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
