mayuehappy commented on a change in pull request #17525:
URL: https://github.com/apache/flink/pull/17525#discussion_r741657453
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBRocksStateKeysAndNamespacesIteratorTest.java
##########
@@ -129,4 +131,74 @@ public void testIterator() throws Exception {
}
}
}
+
+ @Test
+ public void testIteratorUpdateMapStateMultipleTimes() throws Exception {
Review comment:
Very Thanks for reviewing. I total agree with your opinion and I've
moved the test to `StateBackendTestBase`.
BTW , I think it is unnecessary to add a new test but just need to add some
MapState-related case in `#testGetKeysAndNamespaces`. what do you think ?
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
##########
@@ -460,22 +461,66 @@ public void testGetKeysAndNamespaces() throws Exception {
backend.getPartitionedState(
ns1,
StringSerializer.INSTANCE,
- new ValueStateDescriptor<>(fieldName,
IntSerializer.INSTANCE));
+ new ValueStateDescriptor<>(
+ valueStateFieldName,
IntSerializer.INSTANCE));
+
+ MapState<Integer, Integer> keyedState2 =
Review comment:
OK , I noticed that there is a pair of unit tests `#testGetKeys` and
`#testMapStateGetKeys` in `StateBackendTestBase`, which is very similar to my
situation. I referred to these codes when I modified it before.
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
##########
@@ -460,22 +461,66 @@ public void testGetKeysAndNamespaces() throws Exception {
backend.getPartitionedState(
ns1,
StringSerializer.INSTANCE,
- new ValueStateDescriptor<>(fieldName,
IntSerializer.INSTANCE));
+ new ValueStateDescriptor<>(
+ valueStateFieldName,
IntSerializer.INSTANCE));
+
+ MapState<Integer, Integer> keyedState2 =
Review comment:
In addition, I observed that similar tests in StateBackendTestBase seem
to have some duplicate codes.(eg `testListStateRestoreWithWrongSerializers`\
`testValueStateRestoreWithWrongSerializers`
`testMapStateRestoreWithWrongSerializers`)
So maybe it's also fine to add a new test as
`#testMapStateGetKeysAndNamespace` just like` #testMapStateGetKeys ` or do u
have some other greater suggestions ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
