Myasuka commented on a change in pull request #17645:
URL: https://github.com/apache/flink/pull/17645#discussion_r741606981
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/mock/MockKeyedStateBackend.java
##########
@@ -221,9 +226,11 @@ public void notifyCheckpointAborted(long checkpointId) {
@Nonnull CheckpointOptions checkpointOptions) {
return new FutureTask<>(
() ->
- SnapshotResult.of(
- new MockKeyedStateHandle<>(
- copy(stateValues,
stateSnapshotFilters))));
+ emptySnapshot
Review comment:
why we must introduce a `emptySnapshot` here?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java
##########
@@ -149,8 +149,11 @@ private void ensureRunning() throws Exception {
// checking before is not enough because (check + enqueue) is not
atomic
if (wasClosed || !thread.isAlive()) {
cleanupRequests();
- throw ExceptionUtils.firstOrSuppressed(
- new IllegalStateException("not running"), thrown);
+ IllegalStateException exception = new IllegalStateException("not
running");
Review comment:
Do you think we should add a new method in `ExceptionUtils` to represent
this meaning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
