wenlong88 commented on a change in pull request #17509:
URL: https://github.com/apache/flink/pull/17509#discussion_r742482235



##########
File path: 
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/slicing/SlicingWindowOperator.java
##########
@@ -150,6 +158,8 @@ public void open() throws Exception {
                         getKeyedStateBackend(),
                         collector,
                         getRuntimeContext()));
+        // initialize progress of window processor
+        windowProcessor.advanceProgress(currentWatermark);

Review comment:
       I think we should not call advanceProgress here, because it may be 
possible that advanceProgress would generate outputs, which is not allowed in 
open. maybe just add an initialProgess paramter in the constructor?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to