tsreaper commented on a change in pull request #17605:
URL: https://github.com/apache/flink/pull/17605#discussion_r742501383
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/RankHarnessTest.scala
##########
@@ -220,4 +221,74 @@ class RankHarnessTest(mode: StateBackendMode) extends
HarnessTestBase(mode) {
assertor.assertOutputEqualsSorted("result mismatch", expectedOutput,
result)
testHarness.close()
}
+
+ @Test
+ def testUpdateRankWithRowNumber(): Unit = {
Review comment:
Add more test scenarios.
1. Calculate top 5 but there are more than 5 candidates.
2. Sort key drops but ranking does not change.
3. Sort key drops but does not drop to the last ranking.
4. Calculate top 5, 7 candidates, previous rank 3 drops to rank 6 (but it is
still "rank 5").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
