MartijnVisser commented on pull request #17635:
URL: https://github.com/apache/flink/pull/17635#issuecomment-960686850


   @fapaul `flink-connector-hbase-1.4` pulls `jaxb-impl` in via Hadoop 
dependencies, which is the same behaviour as currently on master. 
   
   ```
   [INFO] org.apache.flink:flink-connector-hbase-1.4:jar:1.15-SNAPSHOT
   [INFO] +- org.apache.hbase:hbase-server:test-jar:tests:1.4.3:test
   [INFO] |  +- org.apache.hbase:hbase-common:jar:1.4.3:compile
   [INFO] |  +- org.apache.hbase:hbase-protocol:jar:1.4.3:compile
   [INFO] |  +- org.apache.hbase:hbase-procedure:jar:1.4.3:test
   [INFO] |  +- org.apache.hbase:hbase-prefix-tree:jar:1.4.3:test
   [INFO] |  +- org.apache.hbase:hbase-metrics-api:jar:1.4.3:test
   [INFO] |  +- org.apache.hbase:hbase-metrics:jar:1.4.3:test
   [INFO] |  |  \- io.dropwizard.metrics:metrics-core:jar:3.1.2:test
   [INFO] |  +- commons-httpclient:commons-httpclient:jar:3.1:compile
   [INFO] |  +- commons-codec:commons-codec:jar:1.15:compile
   [INFO] |  +- org.apache.hbase:hbase-hadoop-compat:jar:1.4.3:test
   [INFO] |  +- org.apache.hbase:hbase-hadoop2-compat:jar:1.4.3:test
   [INFO] |  +- com.yammer.metrics:metrics-core:jar:2.2.0:compile
   [INFO] |  +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
   [INFO] |  +- com.sun.jersey:jersey-core:jar:1.9:compile
   [INFO] |  +- com.sun.jersey:jersey-server:jar:1.9:compile
   [INFO] |  |  \- asm:asm:jar:3.1:compile
   [INFO] |  +- commons-cli:commons-cli:jar:1.4:compile
   [INFO] |  +- commons-io:commons-io:jar:2.11.0:compile
   [INFO] |  +- commons-lang:commons-lang:jar:2.6:compile
   [INFO] |  +- commons-logging:commons-logging:jar:1.1.3:compile
   [INFO] |  +- org.apache.commons:commons-math:jar:2.2:test
   [INFO] |  +- org.apache.zookeeper:zookeeper:jar:3.4.14:compile
   [INFO] |  |  +- com.github.spotbugs:spotbugs-annotations:jar:3.1.9:compile
   [INFO] |  |  \- org.apache.yetus:audience-annotations:jar:0.5.0:compile
   [INFO] |  +- org.mortbay.jetty:jetty:jar:6.1.26:compile
   [INFO] |  +- org.mortbay.jetty:jetty-util:jar:6.1.26:compile
   [INFO] |  +- org.mortbay.jetty:jetty-sslengine:jar:6.1.26:test
   [INFO] |  +- org.mortbay.jetty:jsp-2.1:jar:6.1.14:test
   [INFO] |  +- org.mortbay.jetty:jsp-api-2.1:jar:6.1.14:test
   [INFO] |  +- org.mortbay.jetty:servlet-api-2.5:jar:6.1.14:test
   [INFO] |  +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
   [INFO] |  +- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile
   [INFO] |  +- org.codehaus.jackson:jackson-jaxrs:jar:1.9.13:compile
   [INFO] |  +- tomcat:jasper-compiler:jar:5.5.23:runtime
   [INFO] |  +- tomcat:jasper-runtime:jar:5.5.23:runtime
   [INFO] |  |  \- commons-el:commons-el:jar:1.0:runtime
   [INFO] |  +- org.jamon:jamon-runtime:jar:2.4.1:test
   [INFO] |  +- org.apache.htrace:htrace-core:jar:3.1.0-incubating:compile
   [INFO] |  +- com.lmax:disruptor:jar:3.4.2:test
   [INFO] |  +- org.apache.httpcomponents:httpclient:jar:4.5.13:compile
   [INFO] |  +- org.apache.httpcomponents:httpcore:jar:4.4.14:compile
   [INFO] |  +- org.apache.hadoop:hadoop-common:jar:2.4.1:compile
   [INFO] |  |  +- org.apache.hadoop:hadoop-annotations:jar:2.4.1:compile
   [INFO] |  |  +- commons-net:commons-net:jar:3.1:compile
   [INFO] |  |  +- com.sun.jersey:jersey-json:jar:1.9:compile
   [INFO] |  |  |  +- org.codehaus.jettison:jettison:jar:1.1:compile
   [INFO] |  |  |  +- com.sun.xml.bind:jaxb-impl:jar:2.2.3-1:compile
   NB: I removed some lines in this excerpt for readability purposes
   ```
   
   Same thing for `flink-connector-hbase-2.2`
   ```
   [INFO] org.apache.flink:flink-connector-hbase-2.2:jar:1.15-SNAPSHOT
   [INFO] +- org.apache.hadoop:hadoop-common:jar:2.4.1:provided
   [INFO] |  +- org.apache.hadoop:hadoop-annotations:jar:2.4.1:provided
   [INFO] |  +- com.google.guava:guava:jar:11.0.2:provided
   [INFO] |  +- commons-cli:commons-cli:jar:1.4:provided
   [INFO] |  +- xmlenc:xmlenc:jar:0.52:provided
   [INFO] |  +- commons-httpclient:commons-httpclient:jar:3.1:provided
   [INFO] |  +- commons-codec:commons-codec:jar:1.15:compile
   [INFO] |  +- commons-io:commons-io:jar:2.11.0:compile
   [INFO] |  +- commons-net:commons-net:jar:3.1:provided
   [INFO] |  +- javax.servlet:servlet-api:jar:2.5:provided
   [INFO] |  +- org.mortbay.jetty:jetty:jar:6.1.26:provided
   [INFO] |  +- org.mortbay.jetty:jetty-util:jar:6.1.26:provided
   [INFO] |  +- com.sun.jersey:jersey-core:jar:1.9:provided
   [INFO] |  +- com.sun.jersey:jersey-json:jar:1.9:provided
   [INFO] |  |  +- org.codehaus.jettison:jettison:jar:1.1:provided
   [INFO] |  |  +- com.sun.xml.bind:jaxb-impl:jar:2.2.3-1:provided
   ```
   
   What is interesting, is that both `flink-sql-connector-hbase-1.4` and 
`flink-sql-connector-hbase-2.2` don't have this dependency and have an overall 
smaller dependency footprint. I think we should open a follow-up Jira for 
having one HBase connector, which should have that small dependency footprint. 
LMKWYT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to