MartijnVisser commented on pull request #17676: URL: https://github.com/apache/flink/pull/17676#issuecomment-961316929
@eskabetxe Thank you very much for your PR! There are currently two checkstyle violations, which causes the CI to fail. With regards to testing, I think it's important to also add an e2e test for the Oracle dialect, like we already have for MySQL and Postgress in https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/xa/JdbcExactlyOnceSinkE2eTest.java I do believe that would require https://github.com/apache/flink/pull/17646 to be merged first, since that update of testcontainers will add support for Oracle XE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
