[ 
https://issues.apache.org/jira/browse/FLINK-24592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438943#comment-17438943
 ] 

Sergey Nuyanzin commented on FLINK-24592:
-----------------------------------------

Looks like from one side fix for this issue is ready from the other side it is 
a part of FLIP-189 => waiting for voting which has been started here 
https://lists.apache.org/thread/f14jjhrscrdv7h6zw6h1k72nfx232qxs

> FlinkSQL multiline parser improvements
> --------------------------------------
>
>                 Key: FLINK-24592
>                 URL: https://issues.apache.org/jira/browse/FLINK-24592
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Client
>            Reporter: Sergey Nuyanzin
>            Priority: Major
>
> Currently existing multiline parser has limitations e.g.
> line could not end with semicolon e.g. as a part of field value, comment or 
> column name.
> Also if a query contains '--' e.g. as a part of varchar field value then it 
> fails.
> In case there is no objections I would put some efforts to improve this 
> behavior;
> here it is a list of sample problem queries
> {code:sql}
> select 123; -- comment
> select 1 as `1--`;
> select '--';
> -- This query works if a user copy-pastes it to FlinkSQL, however it fails if 
> a user types it in FlinkSQL
> select '1;
> ';
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to