[ 
https://issues.apache.org/jira/browse/FLINK-24046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17439002#comment-17439002
 ] 

Yun Tang commented on FLINK-24046:
----------------------------------

[~Zakelly] Since {{DefaultConfigurableOptionsFactory}} had existed in 
[documentation|https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/ops/state/state_backends/#passing-options-factory-to-rocksdb]
 for long time. I don't think we should remove it directly to backward 
compatibility.

> Refactor the relationship bwtween PredefinedOptions and 
> RocksDBConfigurableOptions
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-24046
>                 URL: https://issues.apache.org/jira/browse/FLINK-24046
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / State Backends
>            Reporter: Yun Tang
>            Assignee: Zakelly Lan
>            Priority: Major
>             Fix For: 1.14.1
>
>
> RocksDBConfigurableOptions mainly focus on the settings of DBOptions and 
> ColumnFamilyOptions. The original design of this class is used to let user 
> could configure RocksDB via configurations instead of programmatically 
> implemented RocksDBOptionsFactory.
> To make the minimal change, original options in RocksDBConfigurableOptions 
> have no default value so that we would not make anything happen in 
> DefaultConfigurableOptionsFactory just as before.
> However, this make user not so clear of the option meaning with no default 
> value, and we could consider change the relationship between them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to