MartijnVisser commented on a change in pull request #17696:
URL: https://github.com/apache/flink/pull/17696#discussion_r743651095
##########
File path: flink-connectors/flink-connector-kafka/pom.xml
##########
@@ -111,6 +111,15 @@ under the License.
<scope>test</scope>
</dependency>
+ <!-- Required to execute the kafka server for testing. Please
change the zookeeper version accordingly when changing the Kafka version
+
https://github.com/apache/kafka/blob/839b886f9b732b151e1faeace7303c80641c08c4/gradle/dependencies.gradle#L122
-->
+ <dependency>
+ <groupId>org.apache.zookeeper</groupId>
+ <artifactId>zookeeper</artifactId>
+ <version>3.5.9</version>
+ <scope>test</scope>
+ </dependency>
+
Review comment:
I believe @dmvk was looking into dropping Zookeeper 3.4 for 1.15, so
would that also solve this issue then?
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/FlinkKafkaInternalProducer.java
##########
@@ -154,20 +161,6 @@ public void close() {
"Close without timeout is now allowed because it can leave
lingering Kafka threads.");
}
- @Override
- public void close(long timeout, TimeUnit unit) {
- synchronized (producerClosingLock) {
- kafkaProducer.close(timeout, unit);
- if (LOG.isDebugEnabled()) {
- LOG.debug(
- "Closed internal KafkaProducer {}. Stacktrace: {}",
- System.identityHashCode(this),
-
Joiner.on("\n").join(Thread.currentThread().getStackTrace()));
- }
- closed = true;
- }
- }
-
Review comment:
Don't we need this anymore or is this no longer possible?
##########
File path:
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/DockerImageVersions.java
##########
@@ -33,7 +33,7 @@
public static final String ELASTICSEARCH_6 =
"docker.elastic.co/elasticsearch/elasticsearch-oss:6.3.1";
- public static final String KAFKA = "confluentinc/cp-kafka:5.5.2";
+ public static final String KAFKA = "confluentinc/cp-kafka:6.2.1";
Review comment:
Shouldn't we also update
https://github.com/fapaul/flink/blob/FLINK-24765/flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/KafkaSourceE2ECase.java#L37
and
https://github.com/fapaul/flink/blob/FLINK-24765/flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceITCase.java#L248
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
