zhipeng93 commented on a change in pull request #18:
URL: https://github.com/apache/flink-ml/pull/18#discussion_r744116336
##########
File path:
flink-ml-iteration/src/main/java/org/apache/flink/iteration/datacache/nonkeyed/DataCacheWriter.java
##########
@@ -43,6 +43,10 @@
private final List<Segment> finishSegments;
private SegmentWriter currentSegment;
+ /**
+ * The segments that are newly added that has not been retrieved by
getNewlyFinishedSegments().
+ */
+ private final List<Segment> newlyFinishedSegments;
Review comment:
Hi Yun, you are right.
I have removed `newlyFinishedSegments` by including the pending elements
into the `finishSegments` of new writers. Please checkout `DataCacheWriter#Line
57`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
