cshuo commented on a change in pull request #17634:
URL: https://github.com/apache/flink/pull/17634#discussion_r744380537



##########
File path: 
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java
##########
@@ -759,6 +760,24 @@
                                             explicit(DataTypes.STRING()))))
                     .build();
 
+    /**
+     * Special "+" operator used internally by {@code SumAggFunction} to 
implement SUM aggregation
+     * on a Decimal type. Uses the {@link 
LogicalTypeMerging#findSumAggType(LogicalType)} to avoid
+     * the normal {@link #PLUS} override the special calculation for precision 
and scale needed by
+     * SUM.
+     */
+    public static final BuiltInFunctionDefinition PLUS_AGG =
+            BuiltInFunctionDefinition.newBuilder()
+                    .name("PLUS_AGG")

Review comment:
       `PLUS_AGG` looks like an aggregate function..Maybe 
`AGG_PLUS`、`PLUS_FOR_AGG`..




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to