JingsongLi commented on pull request #17699:
URL: https://github.com/apache/flink/pull/17699#issuecomment-962830715


   Thanks @lincoln-lil 
   Note `SinkUpsertMaterializer` requires update before.
   We should not separate the inference of change log mode from the sink upsert 
materializer, which will lead to bugs. We should put both the inference and 
sink upsert mode in one place.
   I think we should introduce something like `RankProcessStrategy` of rank in 
`FlinkChangelogModeInferenceProgram`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to