MartijnVisser commented on pull request #17695: URL: https://github.com/apache/flink/pull/17695#issuecomment-962866327
`commons-cli` is bundled with `org.apache.hbase.thirdparty:hbase-shaded-miscellaneous`. Flink is getting that dependency in via `org.apache.hbase:hbase-client:jar` version 2.2.1 according to the dependency tree. ``` [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ flink-sql-connector-hbase-2.2 --- [INFO] org.apache.flink:flink-sql-connector-hbase-2.2:jar:1.15-SNAPSHOT [INFO] +- org.apache.flink:flink-connector-hbase-2.2:jar:1.15-SNAPSHOT:compile [INFO] | +- org.apache.flink:flink-connector-hbase-base:jar:1.15-SNAPSHOT:compile [INFO] | +- org.apache.hbase:hbase-client:jar:2.2.3:compile [INFO] | | +- org.apache.hbase.thirdparty:hbase-shaded-protobuf:jar:2.2.1:compile [INFO] | | +- org.apache.hbase:hbase-common:jar:2.2.3:compile [INFO] | | | \- com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile [INFO] | | +- org.apache.hbase:hbase-hadoop-compat:jar:2.2.3:compile [INFO] | | | \- org.apache.hbase:hbase-metrics-api:jar:2.2.3:compile [INFO] | | +- org.apache.hbase:hbase-hadoop2-compat:jar:2.2.3:compile [INFO] | | | \- org.apache.hbase:hbase-metrics:jar:2.2.3:compile [INFO] | | +- org.apache.hbase:hbase-protocol-shaded:jar:2.2.3:compile [INFO] | | +- org.apache.hbase:hbase-protocol:jar:2.2.3:compile [INFO] | | +- commons-codec:commons-codec:jar:1.15:compile [INFO] | | +- commons-io:commons-io:jar:2.11.0:compile [INFO] | | +- org.apache.commons:commons-lang3:jar:3.3.2:compile [INFO] | | +- org.apache.hbase.thirdparty:hbase-shaded-miscellaneous:jar:2.2.1:compile [INFO] | | | \- com.google.errorprone:error_prone_annotations:jar:2.3.3:compile [INFO] | | +- com.google.protobuf:protobuf-java:jar:2.5.0:compile [INFO] | | +- org.apache.hbase.thirdparty:hbase-shaded-netty:jar:2.2.1:compile [INFO] | | +- org.apache.zookeeper:zookeeper:jar:3.4.14:compile [INFO] | | | \- com.github.spotbugs:spotbugs-annotations:jar:3.1.9:compile [INFO] | | +- org.apache.htrace:htrace-core4:jar:4.2.0-incubating:compile [INFO] | | +- org.jruby.jcodings:jcodings:jar:1.0.18:compile [INFO] | | +- org.jruby.joni:joni:jar:2.1.11:compile [INFO] | | +- io.dropwizard.metrics:metrics-core:jar:3.2.6:compile [INFO] | | +- org.apache.commons:commons-crypto:jar:1.0.0:compile [INFO] | | \- org.apache.yetus:audience-annotations:jar:0.5.0:compile [INFO] | \- io.netty:netty-all:jar:4.1.46.Final:compile [INFO] +- org.slf4j:slf4j-api:jar:1.7.15:provided [INFO] +- com.google.code.findbugs:jsr305:jar:1.3.9:provided [INFO] +- org.apache.flink:flink-test-utils-junit:jar:1.15-SNAPSHOT:test [INFO] +- org.apache.flink:flink-shaded-force-shading:jar:14.0:compile [INFO] +- org.junit.jupiter:junit-jupiter:jar:5.7.2:test [INFO] | +- org.junit.jupiter:junit-jupiter-api:jar:5.7.2:test [INFO] | | +- org.opentest4j:opentest4j:jar:1.2.0:test [INFO] | | \- org.junit.platform:junit-platform-commons:jar:1.7.2:test [INFO] | +- org.junit.jupiter:junit-jupiter-params:jar:5.7.2:test [INFO] | \- org.junit.jupiter:junit-jupiter-engine:jar:5.7.2:test [INFO] +- org.junit.vintage:junit-vintage-engine:jar:5.7.2:test [INFO] | +- org.apiguardian:apiguardian-api:jar:1.1.0:test [INFO] | +- org.junit.platform:junit-platform-engine:jar:1.7.2:test [INFO] | \- junit:junit:jar:4.13.2:test [INFO] +- org.mockito:mockito-core:jar:2.21.0:test [INFO] | +- net.bytebuddy:byte-buddy:jar:1.8.15:test [INFO] | +- net.bytebuddy:byte-buddy-agent:jar:1.8.15:test [INFO] | \- org.objenesis:objenesis:jar:2.1:test [INFO] +- org.powermock:powermock-module-junit4:jar:2.0.4:test [INFO] | +- org.powermock:powermock-module-junit4-common:jar:2.0.4:test [INFO] | | +- org.powermock:powermock-reflect:jar:2.0.4:test [INFO] | | \- org.powermock:powermock-core:jar:2.0.4:test [INFO] | | \- org.javassist:javassist:jar:3.24.0-GA:test [INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test [INFO] +- org.powermock:powermock-api-mockito2:jar:2.0.4:test [INFO] | \- org.powermock:powermock-api-support:jar:2.0.4:test [INFO] +- org.hamcrest:hamcrest-all:jar:1.3:test [INFO] +- org.testcontainers:junit-jupiter:jar:1.16.0:test [INFO] | \- org.testcontainers:testcontainers:jar:1.16.0:test [INFO] | +- org.apache.commons:commons-compress:jar:1.21:test [INFO] | +- org.rnorth.duct-tape:duct-tape:jar:1.0.8:test [INFO] | +- com.github.docker-java:docker-java-api:jar:3.2.11:test [INFO] | | \- com.fasterxml.jackson.core:jackson-annotations:jar:2.12.1:test [INFO] | \- com.github.docker-java:docker-java-transport-zerodep:jar:3.2.11:test [INFO] | +- com.github.docker-java:docker-java-transport:jar:3.2.11:test [INFO] | \- net.java.dev.jna:jna:jar:5.8.0:test [INFO] +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.14.1:test [INFO] +- org.apache.logging.log4j:log4j-api:jar:2.14.1:test [INFO] +- org.apache.logging.log4j:log4j-core:jar:2.14.1:test [INFO] \- org.apache.logging.log4j:log4j-1.2-api:jar:2.14.1:test ``` If I look at the source for that bundled version, that's hardcoded set to 1.4. See https://github.com/apache/hbase-thirdparty/blob/rel/2.2.1/hbase-shaded-miscellaneous/pom.xml. So I think the NOTICE file is actually correctly and shouldn't be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
