matriv commented on a change in pull request #17634:
URL: https://github.com/apache/flink/pull/17634#discussion_r744492537
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/ExprCodeGenerator.scala
##########
@@ -834,6 +834,11 @@ class ExprCodeGenerator(ctx: CodeGeneratorContext,
nullableInput: Boolean)
case BuiltInFunctionDefinitions.JSON_STRING =>
new JsonStringCallGen(call).generate(ctx, operands, resultType)
+ case BuiltInFunctionDefinitions.PLUS_AGG =>
+ val left = operands.head
+ val right = operands(1)
Review comment:
Didn't add this check here (runtime) for performance purpose, since this
is already checked 2 times, only the `DecimalSumAggFunction` is calling this
op, moreover the args are checked in `DecimalSumAggFunction`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
