twalthr commented on a change in pull request #17658:
URL: https://github.com/apache/flink/pull/17658#discussion_r744501858
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/casting/CastRulesTest.java
##########
@@ -350,34 +356,63 @@ private static CastTestSpecBuilder testCastTo(DataType
targetType) {
}
private CastTestSpecBuilder fromCase(DataType dataType, Object src,
Object target) {
- this.inputTypes.add(dataType);
- this.inputData.add(src);
- this.expectedValues.add(target);
- this.castContexts.add(
+ return fromCase(
+ dataType,
CastRule.Context.create(
- ZoneId.systemDefault(),
Review comment:
Let's use UTC here instead. Relying on system defaults makes tests
non-deterministic in different CI systems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
