rkhachatryan commented on a change in pull request #17387:
URL: https://github.com/apache/flink/pull/17387#discussion_r744582386
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -682,7 +682,9 @@ private void stopTaskExecutorServices() throws Exception {
try {
changelogStorage =
changelogStoragesManager.stateChangelogStorageForJob(
- jobId,
taskManagerConfiguration.getConfiguration());
+ jobId,
+ taskManagerConfiguration.getConfiguration(),
+
taskManagerMetricGroup.getJobMetricsGroup(jobId));
Review comment:
Could you elaborate why this should be changed?
To me, it doesn't seem directly related to my change; I also don't see any
obvious reasons why one way is better than the other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
