twalthr commented on a change in pull request #17634:
URL: https://github.com/apache/flink/pull/17634#discussion_r744595065
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeMerging.java
##########
@@ -302,15 +302,19 @@ public static LogicalType findSumAggType(LogicalType
argType) {
*
*
<p>https://docs.microsoft.com/en-us/sql/t-sql/data-types/precision-scale-and-length-transact-sql
*
- * <p>The rules although inspired by SQL Server they are not followed
100%, instead the approach
- * of Spark/Hive is followed for adjusting the precision.
+ * <p>The rules (although inspired by SQL Server) they are not followed
100%, instead the
Review comment:
the `they` should have been dropped as well ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
