ysymi commented on a change in pull request #17698:
URL: https://github.com/apache/flink/pull/17698#discussion_r746327931
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/task-manager/log-list/task-manager-log-list.component.html
##########
@@ -29,14 +29,16 @@
<thead>
<tr>
<th>Log Name</th>
- <th>Size (KB)</th>
+ <th [nzSortFn]="sortLastModifiedTimeFn">Last Modified Time</th>
+ <th [nzSortFn]="sortSizeFn">Size (KB)</th>
</tr>
</thead>
<tbody>
- <tr *ngFor="let log of listOfLog">
+ <tr *ngFor="let log of table.data">
Review comment:
@Airblader I added trackBy function and this pr is ready to be reviewed
again.
And please help me to rerun the CI , latest CI check was failed cause by
flink-connector-rabbitmq 's integration-tests which is occasionally I think,
thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
